Conversation
mp-orkes
force-pushed
the
fix/empty-response-body-raises
branch
4 times, most recently
from
September 23, 2026 15:37
9b13944 to
1bb8bce
Compare
A successful response carrying no workflow id came back as a null return value, so a caller saw a successful start with no id and no way to find the execution. It now raises instead. Scoped to startWorkflow; deserialization is unchanged for every other endpoint. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mp-orkes
force-pushed
the
fix/empty-response-body-raises
branch
from
September 23, 2026 15:43
1bb8bce to
758c8d8
Compare
mp-orkes
marked this pull request as ready for review
September 23, 2026 15:48
mp-orkes
changed the title
startWorkflow on a successful response with an empty body
mp-orkes
changed the title
startWorkflow on a successful response with an empty bodystartWorkflow throws on 200 response with an empty body
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During safety testing, with infrastructure being killed (on purpose), the server answered
startWorkflowwith HTTP 200 and an empty body once in ~150k request. The workflow was not created.The client returned
nullfor that. Anullid is an error.Change
startWorkflownow throws aConductorClientExceptionwhen the response has no workflow id.